Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the performance regression within EvaluateSplits(). #3680

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

canonizer
Copy link
Contributor

  • it turns out creating an std::vector on every call is faster
    than cudaMallocHost()/cudaFreeHost()

- it turns out creating an std::vector on every call is faster
  than cudaMallocHost()/cudaFreeHost()
@RAMitchell RAMitchell merged commit f606cb8 into dmlc:master Sep 8, 2018
CodingCat pushed a commit to CodingCat/xgboost that referenced this pull request Sep 18, 2018
- it turns out creating an std::vector on every call is faster
  than cudaMallocHost()/cudaFreeHost()
alois-bissuel pushed a commit to criteo-forks/xgboost that referenced this pull request Dec 4, 2018
- it turns out creating an std::vector on every call is faster
  than cudaMallocHost()/cudaFreeHost()
@lock lock bot locked as resolved and limited conversation to collaborators Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants